Roundup Tracker - Issues


Author rouilj
Recipients ber, rouilj
Date 2016-07-17.03:15:15
Message-id <>
The reason the message doesn't show up is that NotFound is supposed to
generate a 404 response to the client. The template is changed to 404
in and the _generic.404.html has no support for messages.

I have made two changes:

 1) The response_code is set to 400 before raising the NotFound
    error. 400 (Bad Request) indicates that there is a client side
    issue.  I.E. it fed a bogus column value to the server.

 2)'s NotFound handling is changed to look at the
    response_code and if it is not 400, the usual 404 response_path is
    taken. If the code is 400, the user is presented with the message
    formatted like it is formatted for SeriousError.

The documentation for the NotFound exception doesn't explain when it
should be used. Arguablly SeriousError is the right way to handle this
if NotFound is supposed to be a pure "404" error code.

Suprisingly asking for a non-existent class looks like it doesn't use
the 404 template. E.G. compare: (not using template)
to (using the
     _generic.404.html template)

So Bern should this attached patch be committed?

-- rouilj
Date User Action Args
2016-07-17 03:15:17rouiljsetmessageid: <>
2016-07-17 03:15:17rouiljsetrecipients: + rouilj, ber
2016-07-17 03:15:17rouiljlinkissue2550755 messages
2016-07-17 03:15:16rouiljcreate