Roundup Tracker - Issues

Message6169

Author cmeerw
Recipients cmeerw, joseph_myers, rouilj, schlatterbeck
Date 2018-08-05.06:21:35
Message-id <20180805062132.GP9331@edge.cmeerw.net>
In-reply-to <20180804225642.06D084C029A@itserver6.localdomain>
On Sat, Aug 04, 2018 at 10:56:49PM +0000, John Rouillard wrote:
> In your patch you seed a new random instance, not the default random
> instance. You should also seed the default random instance on every
> client session. The issue with the default pseudorandom number
> [...]
> 
> So make sure you seed the random generator even if we don't use it in
> the main roundup code. It is reasonable for tracker developers to
> think that random is properly seeded on every client connection.

But that's what seed_pseudorandom in client.py is for, isn't it? And I
haven't changed that in this version of the patch. Note that if
SystemRandom is available, this was so far the only instance where the
default random number generator was re-seeded as well - so no change
in that case.
History
Date User Action Args
2018-08-05 06:21:36cmeerwsetrecipients: + cmeerw, schlatterbeck, rouilj, joseph_myers
2018-08-05 06:21:36cmeerwlinkissue2550988 messages
2018-08-05 06:21:35cmeerwcreate