Roundup Tracker - Issues


Author joseph_myers
Recipients joseph_myers, rouilj
Date 2018-09-02.21:47:04
Message-id <>
In-reply-to <20180902212455.C35DD4C067E@itserver6.localdomain>
On Sun, 2 Sep 2018, John Rouillard wrote:

> Does this mean that the code that supports roundup_charset would be
> removed?

Yes.  And all the code deal with conversions if self.charset != 
self.STORAGE_CHARSET, in both and

> If so, is it possible that that could have another use?

I don't see a use for it.

As far as I can tell, unless the form specifies @charset, a 
roundup_charset cookie will never be set in the first place.  And unless 
either the form specifies @charset or there is a roundup_charset cookie, 
the client's charset attribute is set to self.STORAGE_CHARSET (i.e. 
'utf-8') in __init__ and never changed afterwards, so all the code dealing 
with recoding to/from another charset is dead in that case.  And since 
Roundup always generates forms in UTF-8 unless @charset or roundup_charset 
are used, and does not use the accept-charset attribute on forms, form 
responses will always be submitted in UTF-8 so no recoding on input is 
Date User Action Args
2018-09-02 21:47:05joseph_myerssetrecipients: + joseph_myers, rouilj
2018-09-02 21:47:05joseph_myerslinkissue2550998 messages
2018-09-02 21:47:04joseph_myerscreate