Roundup Tracker - Issues

Message6284

Author rouilj
Recipients mathiasb, mbehrle, rouilj, schlatterbeck
Date 2018-10-11.21:48:15
Message-id <20181011214758.C71684C0369@itserver6.localdomain>
In-reply-to <20181011145128.2afb36f1@monsterix.mbehrle.de>
Hi Mathias:

In message <20181011145128.2afb36f1@monsterix.mbehrle.de>,
Mathias Behrle writes:
>* Ralf Schlatterbeck: " Re: [Roundup-devel] [issue2551007] Selection fields
>   are not translated" (Thu, 11 Oct 2018 09:07:43 +0200):
>> On Wed, Oct 10, 2018 at 09:05:30PM -0400, John P. Rouillard wrote:
>> > 
>> > while search_select_translated does:
>> ...
>> >             i18n:translate=""></option>  
>> > [...]
>> > If the content string of the option doesn't exist in the translation
>> > table the content is left untranslated.  
>> 
>> Yes, that's correct.
>> 
>> > >From what info you have provided, I don't know if i18n:translate="" is  
>> > missing from the template's options statement or if there is no
>> > translation for the option label. Either would result in what you see.  
>> 
>> That would also be my first guess, on the other hand this can also
>> be a bug introduced with python3 support.
>> So if the same (unmodified) templates worked with an earlier version
>> of roundup and no longer works now, I would expect this.
>
>Indeed the main reason were lost translations in the po file. After
>re-creating the po file and merging the old translations they now
>appear translated

Do you have the exact steps you took to do this?

Ralf should we open a ticket to do this and check the changes into
mercurial?

> except a few ones:
>- all date/time values in column activity (yesterday, month ago, day,
>  ago...)

Hmm, I see:

  #: ../roundup/date.py:854
  msgid "yesterday"
  msgstr "gestern"

in de.po as well as translations for tomorrow, "just
now". Translations for days seem to be of the form %(number)s days
not just "day". I am not sure if this is a problem with the strings
not being marked for extraction or some other issue.

>- the first item in selection boxes which is '- no selection -'
>  (encountered also when using the jinja2 templates - which I like very
>  much btw.)
>
>The latter item is translated and in the po file:
>
>#: ../html/issue.item.html:122 ../html/issue.item.html:197
>#: ../html/issue.item.html:220
>msgid "- no selection -"
>msgstr "- nichts ausgewählt -"

I see:

  #: ../roundup/cgi/templating.py:1929
  #, python-format
  msgid "<option %svalue=\"-1\">- no selection -</option>"
  msgstr "<option %svalue=\"-1\">- nichts ausgewählt -</option>"

in locale/de.po, so not quite the same.
History
Date User Action Args
2018-10-11 21:48:15rouiljsetrecipients: + rouilj, schlatterbeck, mathiasb, mbehrle
2018-10-11 21:48:15rouiljlinkissue2551007 messages
2018-10-11 21:48:15rouiljcreate