Roundup Tracker - Issues

Message6554

Author rouilj
Recipients rouilj, schlatterbeck
Date 2019-06-21.21:20:44
Message-id <20190621212031.345DE4C042C@itserver6.localdomain>
In-reply-to <20190621162359.a2emrxlvxrjef5v7@runtux.com>
Hi Ralf:

In message <20190621162359.a2emrxlvxrjef5v7@runtux.com>,
Ralf Schlatterbeck writes:
>Thanks, John, for the quick reply.
>So my idea of fixing this looks right.
>
>On Wed, Jun 19, 2019 at 09:46:45PM +0000, John Rouillard wrote:
>> Are you planning on doing something like:
>> 
>> class HttpHeaders:
>[...]
>
>Yes, similar. I've not copied the dict but pass the environ into
>the constructor and mangle incoming names on lookup.

Gotcha.

>I'm not entirely sure if we only need to support get / getheader
>or if all the other dictionary methods should also be supported.
>At least rest.py only uses get.

Might as well just go with these two dictionary methods for now.
We can add more as needed.

>I've just pushed the change, it now works for me.

Cool. Any thought's on how we add tests for these?  All the front ends
need testing and I am at a loss as to how to actually test them.

We could try installing seomthing like:

  https://docs.pylonsproject.org/projects/webtest/en/latest/webtest.html

and I think that could work with cgi, roundup-server, wsgi but I would
prefer something that works without having to install a new library.
History
Date User Action Args
2019-06-21 21:20:44rouiljsetrecipients: + rouilj, schlatterbeck
2019-06-21 21:20:44rouiljlinkissue2551047 messages
2019-06-21 21:20:44rouiljcreate