Roundup Tracker - Issues

Message6583

Author schlatterbeck
Recipients cmeerw, rouilj, schlatterbeck
Date 2019-07-22.18:06:05
Message-id <1563818765.53.0.850559712495.issue2551049@roundup.psfhosted.org>
In-reply-to
Thanks for finding this. The bug is in my (new) test for
mailer.standard_message not in the things it tests.

The roundup mailer interface in python3 uses python strings (unicode)
while python2 uses utf-8. So we get a traceback in python3 when it tries
to *encode* a utf-8 bytes type. The fix is to have the test distinguish
these two cases, looks ugly but I don't think we can avoid the
dependency on the python versions because of the different APIs.

Sorry for not checking if my test passed for py3, I'll try to do that in
the future.

Fix pushed in f767a83a6af0
History
Date User Action Args
2019-07-22 18:06:05schlatterbecksetmessageid: <1563818765.53.0.850559712495.issue2551049@roundup.psfhosted.org>
2019-07-22 18:06:05schlatterbecksetrecipients: + schlatterbeck, rouilj, cmeerw
2019-07-22 18:06:05schlatterbecklinkissue2551049 messages
2019-07-22 18:06:05schlatterbeckcreate