Roundup Tracker - Issues

Message6860

Author jerrykan
Recipients antmail, ber, jerrykan, rouilj
Date 2020-01-14.04:51:17
Message-id <1578977477.7.0.111473680597.issue2550612@roundup.psfhosted.org>
In-reply-to
Sorry to re-open this one, but I have been looking at upgrading one of our internal systems and am able to confirm this is still an issue.

The steps outlined in msg4512 can still be used to produce the incorrect behaviour when running `roundup-demo`.


I've done a bit more digging into the problem and it seems to be due to the section of code locate at:

  http://hg.code.sf.net/p/roundup/code/file/380dec305c28/roundup/cgi/templating.py#l1026

The `current` value is being retrieved from a `HTMLProperty`. If an auditor raises  a `ValueError` then the `HTMLProperty` will contain the value of the property that was submitted in the request, not the value of the property as it is in the DB.

My first instinct would be to change the following line (and some surrounded code) from:

    val = self[k]

to:

    val = self._klass.get(self._nodeid, k)

but depending on the property type we probably won't end up with the text we really want (ie. ids instead of names)
History
Date User Action Args
2020-01-14 04:51:17jerrykansetmessageid: <1578977477.7.0.111473680597.issue2550612@roundup.psfhosted.org>
2020-01-14 04:51:17jerrykansetrecipients: + jerrykan, ber, rouilj, antmail
2020-01-14 04:51:17jerrykanlinkissue2550612 messages
2020-01-14 04:51:17jerrykancreate