On Thu, Apr 02, 2020 at 09:13:48PM +0000, John Rouillard wrote:
> 
> John Rouillard added the comment:
> 
> I think this is the new exception hierarchy that Ralf and I worked out.
> 
> + indicates new exception class
> * indicates exception class needs to be changed
> 
> Inheritence by indentation:

Shouldn't RoundupException inherit from Exception?

Otherwise everything looks fine to me, thanks for your effort!

Ralf

> RoundupException+
>    RejectBase+
>       Reject*
>          RejectRaw
>    RoundupCGIException+
>       HTTPException*
>          Redirect
>          NotFound
>          NotModified
>          PreconditionFailed
>    DetectorError*
>    SendFile*
>    SendStaticFile*
>    SeriousError*
>    
>    NoTemplate*
>    Unauthorised* (2 instances)
> 
>    ConfigurationError*
> 
>    LoginError*
>    Reject*
> 
>    TrackerError*
> 
>    MailUsageHelp*
>    Unauthorized*
>    IgnoreMessage*
>    
> Exception
>    SysCallError - defined in except block on ssl import failure
>    PoSyntaxError
>    
> BaseException
>    SvcShutdown - server should exit on this
>    
> Exceptions defined under:
> 
>  roundup/cgi/TAL/...
>  roundup/cgi/PageTemplates/...
> 
> stay as they are. These are inherited files into roundup.