Roundup Tracker - Issues

Message6993

Author rouilj
Recipients ced, cmeerw, rouilj
Date 2020-10-24.15:10:58
Message-id <20201024151052.3EFF74C0168@itserver6.cs.umb.edu>
In-reply-to <1603529364.7.0.732210980831.issue2551094@roundup.psfhosted.org>
Hi Cédric:

In message <1603529364.7.0.732210980831.issue2551094@roundup.psfhosted.org>,
=?utf-8?q?C=C3=A9dric_Krier?= writes:
>
>As I prefer to not have to patch roundup on each update and because I
>think most end user will prefer the break-on-newline behavior. Here is
>a patch that adds

Very cool. Nice find on mistune's hard_wrap.

One missing piece is to toggle the setting in issue.index.html
template as well so that all 4 markdown (the 4th is simplemde)
renderers agree.

So:

  renderingConfig: {singleLineBreaks: false}

needs to be

  renderingConfig: {singleLineBreaks: true}

when the option is set to true. Christof, would:

   renderingConfig: {singleLineBreaks: {% config.MARKDOWN_BREAK_ON_NEWLINE %} }

work? I assume I am missing something as we want the strings "false"
and "true" here. I am not sure what value is produced by
config.MARKDOWN_BREAK_ON_NEWLINE maybe 0/1.  (If this technique works
it is nicer than how I have been modifying javascript with TAL.)

Cédric once you have verified a working solution please attach a
patch.

It's funny but your test code and mine use the same trick of counting
the number of '<br' in the returned markup.

Thanks for this work. It looks good so far. I am excited to get it
finished and committed.
History
Date User Action Args
2020-10-24 15:10:58rouiljsetrecipients: + rouilj, cmeerw, ced
2020-10-24 15:10:58rouiljlinkissue2551094 messages
2020-10-24 15:10:58rouiljcreate