Roundup Tracker - Issues

Message6997

Author rouilj
Recipients ced, cmeerw, rouilj
Date 2020-10-25.17:19:59
Message-id <1603646399.35.0.59137564377.issue2551094@roundup.psfhosted.org>
In-reply-to
In msg6995 Christof says:

> you could also do something like
>
>  {{ config.MARKDOWN_BREAK_ON_NEWLINE and 'true' or 'false' }}
>
>looks like at the moment we get 0/1 for the string value of the option. 

This is what Cedric used calling the Boolean() javascript constructor
to create a true boolean.

>Just wondering... maybe we shouldn't rely on the string value being
>'0' or '1'

In issue2550905 to discuss testing I mention in msg6744 that we have
no testing for chameleon or jinja2 templating engines and poor
coverage on the TAL engine. Testing for this type of return value
and enforcing it through tests could be a good first test case
for jinja2. Created issue2551095 to test/enforce this.

However even without that test, I am inclined to commit Cedric's
patch including the simplemede template fix.
History
Date User Action Args
2020-10-25 17:19:59rouiljsetmessageid: <1603646399.35.0.59137564377.issue2551094@roundup.psfhosted.org>
2020-10-25 17:19:59rouiljsetrecipients: + rouilj, cmeerw, ced
2020-10-25 17:19:59rouiljlinkissue2551094 messages
2020-10-25 17:19:59rouiljcreate