Roundup Tracker - Issues

Message6998

Author rouilj
Recipients ced, cmeerw, rouilj
Date 2020-10-25.17:38:06
Message-id <1603647486.62.0.214799697199.issue2551094@roundup.psfhosted.org>
In-reply-to
Hi Cedric:

In your patch to templating.py you have:

  +            s = u2s(markdown(s2u(s), self._db.config))
           except Exception:  # when markdown formatting fails return 
markup
  +            raise
               return self.plain(escape=0, hyperlink=hyperlink)
           return s

why was raise added? Doesn't that defeat the ability to return plain
text if the markdown formatter raises an error? It certainly breaks
the markdown tests.

Also in test_tempating.py you have:

  + from operator import setitem

why is this import needed? I don't see any call to setitem.

Have a great day.

-- rouilj
History
Date User Action Args
2020-10-25 17:38:06rouiljsetmessageid: <1603647486.62.0.214799697199.issue2551094@roundup.psfhosted.org>
2020-10-25 17:38:06rouiljsetrecipients: + rouilj, cmeerw, ced
2020-10-25 17:38:06rouiljlinkissue2551094 messages
2020-10-25 17:38:06rouiljcreate