Hi John:

In message <4d988495-a405-0242-af46-64e263b858ad@jerrykan.com>,
John Kristensen writes:
>Looks like I missed that reference to the MANIFEST file, so yes your 
>suggested change would seem to be correct and needs to be included in 
>the patch.

Wilco.

>> Also is looks like MANIFEST.in is still
>> valid for setuptools. I assume the reference for changing
>> MANIFEST.in should change from:
>> 
>>    http://docs.python.org/2/distutils/sourcedist.html#manifest-template
>> 
>> to:
>> 
>>    https://packaging.python.org/guides/using-manifest-in/#using-manifest-
>> in
>> 
>> correct?
>
>It seems the Python2 documentation is the only place that documents what 
>should go in the MANIFEST.in file.
>
>The packaging.python.org links seems to be a dead link (even though it 
>is referenced in other parts of the documentation).

Eep. I just got the link from the docs, never actually tried it 8-/.

>[...]
>However it seems that setuptools does provide alternative methods to 
>using MANIFEST.in, see:
>
>     https://setuptools.readthedocs.io/en/latest/userguide/datafiles.html
>
>My reading of that seem to indicate that we should be using 
>`include_package_data=True` so that backwards compatibility with 
>MANIFEST.in is kept even if we don't use that alternative options.

So add `include_package_data=True` at the end of the setup call after:

 data_files=data_files

Correct?

>> Also I was able to use:
>> 
>>      python3 setup.py sdist --repository test --sign
>> 
>> successfully. I also did a pure sdist and tested the tarball. All
>> tests passed.
>> 
>> I also was able to:
>> 
>>      python3 setup.py bdist_egg --repository test --sign
>>      python3 setup.py bdist_wheel  --repository test --sign
>> 
>> and it seems to work on test.pypi.org.
>> 
>> Do you have a reference on how I can test these? Something similar to
>> (your) step 11 in RELEASE.txt would be good. I don't want egg (ahem)
>> on my face if I deploy these methods.
>
>I'm not sure I follow what you want to test. Are you able to elaborate?

Well when I have an sdist tarball, I unpack it somewhere in /tmp, run
pytest against it. Then I run setup install --prefix (or --user) and
check that expected files are where they should be in the resulting
install.

What is the equivalent test mechanism for an egg or wheel to verify
that they are properly built and will install correctly.
E.G. a dummy example would be:

   python --wheel roundup.whl --entry roundup-admin

to verify that I can start roundup-admin from the wheel.

Roundup isn't just a module to be imported by an application. It is a
set of cli applications, so maybe egg/wheel distribution doesn't make
sense.

Thanks.