Roundup Tracker - Issues

Message7203

Author rouilj
Recipients ced, rouilj
Date 2021-04-19.01:02:51
Message-id <1618794172.11.0.33468020733.issue2551129@roundup.psfhosted.org>
In-reply-to
Hello Cedric:

Applied in rev 6382:b35a50d02890.

Thanks for this patch. You are correct selectTemplate should
be included in the try. The try that you moved to include
selectTemplate includes an except templating.NoTemplate
handler already.

So it looks like that selectTemplate call was just incorrectly
placed.

I applied your patch. I also modified the except NoTemplate clause
to return a 400 response. With just your patch it returned a 200
code to the client which isn't right as the client is sending garbage.

I dusted off a test I have been working on for this case. Was going
to create the test first then fix the issue.

IIUC crawlers usually just follow existing links. Any idea how
they are ending up with the invalid template value? Is roundup
generating a broken template seeing somewhere? Do you have any
idea how this is happening? I see it on the crawlers for my demo
instance as well. It looks like it i using @template=empty.
History
Date User Action Args
2021-04-19 01:02:52rouiljsetmessageid: <1618794172.11.0.33468020733.issue2551129@roundup.psfhosted.org>
2021-04-19 01:02:52rouiljsetrecipients: + rouilj, ced
2021-04-19 01:02:52rouiljlinkissue2551129 messages
2021-04-19 01:02:51rouiljcreate