Hi Ralf:
In message <20211207155349.mz6kgvfevhjht36e@runtux.com>,
Ralf Schlatterbeck writes:
>On Tue, Dec 07, 2021 at 03:18:11PM +0000, John Rouillard wrote:
>> >John, would you agree that setting these headers to '' instead of
>> >None would still fulfill the original intention? I've tested this
>> >will not produce a traceback.
>>
>> According to what I remember, these headers should not be emitted at
>> all.
>>
>> Does this change to client.py solve the issue?
>
>Hmm, can't test immediately: This is a "production" (sort-of) system
Fair enough.
Neat idea about keeping your logs in Roundup. Wish I had known about it
would have made an interesting use case for my article.
>So this isn't the typical json request but a file upload with another
>content-type.
That may be an important point.
>On inspection that patch looks like it should work.
>Feel free to commit & push and I'll close the issue if it works for me
>or tell you when I download pictures next time ;-)
Done changeset: 6544:9aa8df0b4426.
>> Also shouldn't test*Post*() in test/rest_common.py have shown the
>> issue? Since this appears unique to wsgi, I wonder if a file POST test
>> case test_liveserver.py can trigger it.
>
>If that test checks for file-uploads, yes. But I doubt it does (haven't
>looked).
test/test_anydbm.py::anydbmRestTest::testPostFile
The name is confusing if it doesn't. However it is posting text.
form.list = [
cgi.MiniFieldStorage('content', 'hello\r\nthere')
]
Maybe binary is a different deal? |