Roundup Tracker - Issues

Message7500

Author rouilj
Recipients marcus.priesch, rouilj
Date 2022-05-03.23:06:19
Message-id <1651619179.36.0.0366956480503.issue2551199@roundup.psfhosted.org>
In-reply-to
Hi Marcus:

It looks like most of these patches have been applied in changeset:   6658:408fd477761f
and merged back into default branch in changeset:   6664:ac0df9272162.

However the diff for roundup/cgi/engine_zopetal.py is missing:

-GlobalTranslationService.setGlobalTranslationService(translationService)
+GlobalTranslationService.setGlobalTranslationService(TranslationService.get_translation())

the changesets don't have this change. They remove the call to 
GlobalTranslationService.setGlobalTranslationService entirely. But the file
still imports GlobalTranslationService:

   from roundup.cgi.PageTemplates import PageTemplate, GlobalTranslationService

This looks wrong. I assume the call to:

 GlobalTranslationService.setGlobalTranslationService(TranslationService.get_translation())

should still be there right? If so can you check with Ralf and figure out how it went
missing.

Thanks.

-- rouilj
History
Date User Action Args
2022-05-03 23:06:19rouiljsetmessageid: <1651619179.36.0.0366956480503.issue2551199@roundup.psfhosted.org>
2022-05-03 23:06:19rouiljsetrecipients: + rouilj, marcus.priesch
2022-05-03 23:06:19rouiljlinkissue2551199 messages
2022-05-03 23:06:19rouiljcreate