Roundup Tracker - Issues

Message7501

Author marcus.priesch
Recipients marcus.priesch, rouilj
Date 2022-05-04.05:54:18
Message-id <2c8ebd0b-26ec-f5b0-6154-aa5a982f6942@priesch.co.at>
In-reply-to <1651619179.36.0.0366956480503.issue2551199@roundup.psfhosted.org>
Hi John,

the import is not needed, when you search the code for
'translationService' it is not used anywhere as a global variable.

it is only referenced in GlobaltranslationService.py and in
DummyEngine.py where a *self.*translationService gets assigned with
a DummyTranslationService instance.

grepping for getGlobalTranslationService and setGlobalTranslationService
yields that those are also not used anywhere.

getGlobalTranslationService only gets imported in TALES.py where it is
also not used.

therefore i assume it's not needed at all and can be removed.

i18n for TAL gets injected in cgi.TranslationService.py

i am working here with ralf's tracker and i18n is working with the
changes - and also without the import of GlobalTranslationService in
engine_zopetal.py.

i assume that i just forgot to remove the import when creating the patch.

is the change you are refering in msg7468 this one 6640:6ac3667706be ?

if yes, than i think we can assume things are working without the
GlobalTranslationService import - at least tests pass here without the
import.

attached is the patch to current tip also removing the unused code from
GlobalTranslationService.py (getGlo... and setGlo... and the global ...)

all tests pass ... postgresql and mysql not tested but there should be
no impact on these.

regards,
marcus.
Files
File name Uploaded
templating_form_parser_3.patch marcus.priesch, 2022-05-04.05:54:18
History
Date User Action Args
2022-05-04 05:54:18marcus.prieschsetrecipients: + marcus.priesch, rouilj
2022-05-04 05:54:18marcus.prieschlinkissue2551199 messages
2022-05-04 05:54:18marcus.prieschcreate