Roundup Tracker - Issues

Message776

Author rouilj
Recipients
Date 2003-09-21.18:04:04
Message-id
In-reply-to
Logged In: YES 
user_id=707416

Now that I found the patch and applied it to the sysadmin
tracker, it works. For a final fix, I copied the 
detector/__init__.py file to the same location in my tracker.
I suspect it will work fine.

However in looking at the patch, I am confused a bit.
Why wouldn't this:

            fp = open(path)
            try:
                module = imp.load_module(name, open(path), 
path,
                    ('.py', 'r', imp.PY_SOURCE))

be written as:

            fp = open(path)
            try:
                module = imp.load_module(name, fp, path,
                    ('.py', 'r', imp.PY_SOURCE))

and save the second open call? Also the docs say that
the fp argument must be closed by the caller. Doesn't putting
an open(path) in the function call leave the file handle open,
or is it automatically closed because its assigned to a local 
(parameter) variable?

-- rouilj
History
Date User Action Args
2009-02-03 14:20:20adminlinkissue724714 messages
2009-02-03 14:20:20admincreate