Message8361
Thanks Paul and Bern for your work on this.
Bern you said: 'Debian and Ubuntu do include python3-gpg,'
I can't just install the gpg bindings using apt. CI does not use
the OS packaged python. Installing using apt only affects the OS
packaged python, not the one we are testing against. That's
why pip was used to build/install during CI. (CI would be much much
faster if I didn't have to pip install/compile the world.)
Paul thanks for explaining why '\s' is now failing with 3.12 or newer. Fixing
this is an option, but I think it is better to uses the same upstream
method used to build the vendor packages like python3-gpg.
I had analyzed the original workflow with the skipped PGP tests:
https://github.com/koplas/roundup/actions/runs/13729858872/job/38404537982#step:19:24129
due to missing gpg.
I was not sure if this was because:
* the install is to the wrong python directory (the one we need is under /opt)
* the package name is different and a change to handle older and newer package
names is needed
Also there were warnings about installing using setup.py, and I suggested using pip
to do the install to get it in the right directory etc. But I wasn't sure if using pip
to install the beta was broken (given your comments about upstream package building being broken).
I see you have fixed the above issues and added a tarball to this issue in your last update.
https://github.com/koplas/roundup/actions/runs/13765181443/job/38489865763.
shows these tests are no longer skipped. It would be good to have the steps you took
to build that tarball in case we need to do this again in the future. I am even ok if
we can't just 'pip install gpg' and have to do a full build as long as we have
the directions for doing so.
Once you have this working, I have no issue with your checking any changes into the
roundup repo. Let Ralf S. know. He can push to our github CI instance, or help you
get set up so you can push to it yourself.
Also has anybody been able to try the PGP test using the python3-gpg package on debian/ubuntu
using the native python. All this CI is really trying to make sure that a native OS python
will work for various python versions.
Thank you for your efforts. You got much further than I did/would have.
-- rouilj |
|
Date |
User |
Action |
Args |
2025-03-10 14:12:55 | rouilj | set | messageid: <1741615975.1.0.271212182052.issue2551368@roundup-tracker.org> |
2025-03-10 14:12:55 | rouilj | set | recipients:
+ rouilj, schlatterbeck, ber, pschwabauer |
2025-03-10 14:12:55 | rouilj | link | issue2551368 messages |
2025-03-10 14:12:54 | rouilj | create | |
|