Hi Chris:

tl;dr: If you uninstall redis or build without redis in Docker/
requirements.txt do
       the tests pass?

I'm building a docker container now with test/requirements.txt appended
to scripts/Docker/requirements.txt. I assume you installed the packages
in test/requirements.txt in the docker build to get pytest etc. I don't
think the stage 1 build includes pytest etc.

My first impression issues mentioning redis are ok. IIRC redis tests are
enabled
if the redis module is installed. However if no redis is located at the
configured
path they will fail. That's a test suite bug I should fix if I can
figure out how
to do it.

The two AssertionError and one AttributeError along with the Demo mode
failures
I don't have an explanation for.

========

In my docker container running 'python -m pytest test' with redis
enabled on my
system I get no errors.

Running 'python -v -m pytest test/test_sqlite.py test/test_demo.py' with
redis
shut down, I also get ... no errors. Unexpected given my first
impression.

Running the full test suite with redis shut down using 'pythom -m pytest
test', I get all
the same errors you did except for the 3 demo tests. The redis
connection failures/Session
tests are:

 FAILED test/test_sqlite.py::sqliteSpecialActionTestCase::testInnerMain
- redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testBadTimestamp -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testClear -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testDataTypes -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testDestroy -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testGetAll -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testGetGetAllMissingKey
- redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused. 
 FAILED test/test_sqlite.py::sqliteSessionTest::testGetUniqueKey -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testList -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testSetSession -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testUpdateSession -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.
 FAILED test/test_sqlite.py::sqliteSessionTest::testUpdateTimestamp -
redis.exceptions.ConnectionError: Error 111 connecting to
localhost:6379. Connection refused.

 FAILED test/test_sqlite.py::sqliteSessionTest::testDbType -
AssertionError: 'roundup.backends.sessions_sqlite.Sessions' not found in
'<roundup.backends.sessions_redis.Sessions object at 0x7fcb20f9c0b0>'
 FAILED test/test_sqlite.py::sqliteSessionTest::testLifetime -
AssertionError: 1788628896.575535 not greater than 1789233694.57553
 FAILED test/test_sqlite.py::sqliteSessionTest::testWalMode -
AttributeError: 'Sessions' object has no attribute 'sql'

I think these last three are a side effect of the missing redis server.

If you uninstall redis or build without redis in Docker/requirements.txt
do the tests pass?

I thought I had a fix to skip redis tests if redis module is importable
but the server is not available. But it worked for the
test_redis_session.py test and not the sqlite
tests. I have a feeling something is leaking.


I am still stumped on the demo failures. SystemExit 2 doesn't really
help.