Roundup Tracker - Issues

Issue 2550640

classification
roundup sends emails w/ same in-reply-to and message-id headers for 1st message attached to issue
Type: behavior Severity: normal
Components: Mail interface Versions: 1.4
process
Status: closed
:
: : kowey, richard
Priority: :

Created on 2010-02-22 14:39 by kowey, last changed 2010-02-23 03:21 by richard.

Messages
msg4029 Author: [hidden] (kowey) Date: 2010-02-22 14:39
We just noticed this on http://bugs.darcs.net/issue1751 (roundup 1.4.4
via Debian Lenny).

Digging around a bit, I noticed this roundupdb.py:

            if not inreplyto:
                # Default the reply to the first message
                msgs = self.get(nodeid, 'messages')
                # Assume messages are sorted by increasing message
number here
                if msgs[0] != nodeid:
                    inreplyto = messages.get(msgs[0], 'messageid')
                    if inreplyto:
                        writer.addheader('In-Reply-To', inreplyto)

Could that be the culprit?  It seems like the very first message in an
issue gets this, whereas subsequent messages have correct-looking
in-reply-to headers.

Is it actually bad for messages to be replies to themselves?  Why not
just not have an In-Reply-To header for just cases?
msg4030 Author: [hidden] (richard) Date: 2010-02-23 03:21
Right, that should be "msgid" there, not "nodeid" (which for clarity
is being changed to "issueid" in the source).

Thanks for the report. Fixed in r4464

On Tue, Feb 23, 2010 at 1:39 AM, Eric Kow <issues@roundup-tracker.org> wrote:
>
> New submission from Eric Kow <kowey@darcs.net>:
>
> We just noticed this on http://bugs.darcs.net/issue1751 (roundup 1.4.4
> via Debian Lenny).
>
> Digging around a bit, I noticed this roundupdb.py:
>
>            if not inreplyto:
>                # Default the reply to the first message
>                msgs = self.get(nodeid, 'messages')
>                # Assume messages are sorted by increasing message
> number here
>                if msgs[0] != nodeid:
>                    inreplyto = messages.get(msgs[0], 'messageid')
>                    if inreplyto:
>                        writer.addheader('In-Reply-To', inreplyto)
>
> Could that be the culprit?  It seems like the very first message in an
> issue gets this, whereas subsequent messages have correct-looking
> in-reply-to headers.
>
> Is it actually bad for messages to be replies to themselves?  Why not
> just not have an In-Reply-To header for just cases?
>
> ----------
> components: Mail interface
> messages: 4029
> nosy: kowey
> severity: normal
> status: new
> title: roundup sends emails w/ same in-reply-to and message-id headers for 1st message attached to issue
> type: behavior
> versions: 1.4
>
> ________________________________________________
> Roundup tracker <issues@roundup-tracker.org>
> <http://issues.roundup-tracker.org/issue2550640>
> ________________________________________________
>
History
Date User Action Args
2010-02-23 03:21:24richardsetstatus: new -> closed
nosy: + richard
messages: + msg4030
2010-02-22 14:39:37koweycreate