Create a query that has one of the 'no sort or group' radio buttons
selected. When you go to edit this query the settings for the 'no sort
or group' option are not retained, but are instead set to the default.
This can be annoying then wanting to make minor changes to existing
queries and forget to set the sort or group options again.

See patch for a proposed fix

John, thanks for feedback and the patch.
I wonder if other templates also have the issue.

Bernhard, I'm not sure if there would be similar issues in other
templates, but my guess would be probably not.

The saved queries seem to be a part of the systems that doesn't see a
whole log of use (at least for us). We have been using roundup for about
18 months and only one user (out of ~50 frequent users) picked up on
this bug. I am assuming if there were similar problems in the other
"high use" areas, someone would have noticed by now.

The patch works as expected:

- I tested this against the demo instance before and after applying the
patch.

- Ensured all the tests pass (this is just a change to the HTML code,
but still wanted to make sure).

Based on my review, this patch is good to go.

A note:

Possibly because of a change in the original file (issue.search.html),
the offset of the second part of the patch (line 167) has changed by one
(now line 168):

$ patch -p0 < issue.search.html.patch 
patching file share/roundup/templates/classic/html/issue.search.html
Hunk #2 succeeded at 168 (offset 1 line).

Since patch can handle this, IMO no change is required for the patch.

Thanks Satchit, Thanks John!
I've committed the patch!

I wonder if we should add some update instructions
for people migrating. They would have to update their template,
right?

Commited with rev4642

Since this patch appears to have been commited, should the issue
be changed to status:closed resolution:fixed?

I guess I was wondering if we need to add some update instructions.
(Which was my last question)

I guess figuring out the best way to document changes in templates might
be a good start. Part of the problem with roundup is that it is so
flexible, and people will generally add their own customisations to
templates.

Other than generating a diff of all of the template files for each
template just before release, is there a good way to document changes in
any concise way?

Personally I think the best way to upgrade is to do a three-way merge
with the old version, new version, and the customised version of the
template... but that isn't really documentation.

This patch was released on/in:

 2012-05-15: 1.4.20

to documenting patches to the templates is still an open issue.

I claim the ticket number in the CHANGES.txt file is sufficient
to find the ticket that should have a patch attached or a reference to
the hg checkin that fixed the issue.

The user can pull the diff from there.

I don't think supplying a diff for every release really scales.

Is there a simple set of directions that will allow the end user/admin
to generate a diff on their own that they can try to apply?