Issue 2550695
Created on 2011-03-28 05:50 by jerrykan, last changed 2011-07-19 07:55 by ber.
| msg4264 (view) |
Author: [hidden] (jerrykan) |
Date: 2011-03-28 05:50 |
|
Create a query that has one of the 'no sort or group' radio buttons
selected. When you go to edit this query the settings for the 'no sort
or group' option are not retained, but are instead set to the default.
This can be annoying then wanting to make minor changes to existing
queries and forget to set the sort or group options again.
See patch for a proposed fix
|
| msg4265 (view) |
Author: [hidden] (ber) |
Date: 2011-03-30 11:04 |
|
John, thanks for feedback and the patch.
I wonder if other templates also have the issue.
|
| msg4298 (view) |
Author: [hidden] (jerrykan) |
Date: 2011-04-18 01:45 |
|
Bernhard, I'm not sure if there would be similar issues in other
templates, but my guess would be probably not.
The saved queries seem to be a part of the systems that doesn't see a
whole log of use (at least for us). We have been using roundup for about
18 months and only one user (out of ~50 frequent users) picked up on
this bug. I am assuming if there were similar problems in the other
"high use" areas, someone would have noticed by now.
|
| msg4348 (view) |
Author: [hidden] (satchit) |
Date: 2011-07-18 22:15 |
|
The patch works as expected:
- I tested this against the demo instance before and after applying the
patch.
- Ensured all the tests pass (this is just a change to the HTML code,
but still wanted to make sure).
Based on my review, this patch is good to go.
A note:
Possibly because of a change in the original file (issue.search.html),
the offset of the second part of the patch (line 167) has changed by one
(now line 168):
$ patch -p0 < issue.search.html.patch
patching file share/roundup/templates/classic/html/issue.search.html
Hunk #2 succeeded at 168 (offset 1 line).
Since patch can handle this, IMO no change is required for the patch.
|
| msg4351 (view) |
Author: [hidden] (ber) |
Date: 2011-07-19 07:55 |
|
Thanks Satchit, Thanks John!
I've committed the patch!
I wonder if we should add some update instructions
for people migrating. They would have to update their template,
right?
|
| msg4352 (view) |
Author: [hidden] (ber) |
Date: 2011-07-19 07:55 |
|
Commited with rev4642
|
|
| Date |
User |
Action |
Args |
| 2011-07-19 07:55:42 | ber | set | messages:
+ msg4352 |
| 2011-07-19 07:55:22 | ber | set | messages:
+ msg4351 |
| 2011-07-18 22:15:28 | satchit | set | nosy:
+ satchit messages:
+ msg4348 |
| 2011-04-18 01:45:53 | jerrykan | set | messages:
+ msg4298 |
| 2011-03-30 11:04:17 | ber | set | nosy:
+ ber messages:
+ msg4265 |
| 2011-03-28 05:50:33 | jerrykan | create | |
|