Roundup Tracker - Issues

Message4348

Author satchit
Recipients ber, jerrykan, satchit
Date 2011-07-18.22:15:28
Message-id <1311027328.79.0.20392634629.issue2550695@psf.upfronthosting.co.za>
In-reply-to
The patch works as expected:

- I tested this against the demo instance before and after applying the
patch.

- Ensured all the tests pass (this is just a change to the HTML code,
but still wanted to make sure).

Based on my review, this patch is good to go.

A note:

Possibly because of a change in the original file (issue.search.html),
the offset of the second part of the patch (line 167) has changed by one
(now line 168):

$ patch -p0 < issue.search.html.patch 
patching file share/roundup/templates/classic/html/issue.search.html
Hunk #2 succeeded at 168 (offset 1 line).

Since patch can handle this, IMO no change is required for the patch.
History
Date User Action Args
2011-07-18 22:15:28satchitsetmessageid: <1311027328.79.0.20392634629.issue2550695@psf.upfronthosting.co.za>
2011-07-18 22:15:28satchitsetrecipients: + satchit, ber, jerrykan
2011-07-18 22:15:28satchitlinkissue2550695 messages
2011-07-18 22:15:28satchitcreate