Roundup Tracker - Issues

Issue 1083570

classification
(list) popups do not work
Type: Severity: normal
Components: Web interface Versions:
process
Status: closed fixed
:
: richard : mstarzyk, richard
Priority: normal :

Created on 2004-12-11 19:26 by mstarzyk, last changed 2004-12-14 23:27 by richard.

Files
File name Uploaded Description Edit Remove
opera.txt mstarzyk, 2004-12-11 19:37
_generic.help.html.patch mstarzyk, 2004-12-11 23:52 Patch
Messages
msg1567 Author: [hidden] (mstarzyk) Date: 2004-12-11 19:26
Roundup: 0.8.0 b1
Browser: MSIE, Opera 7.54 on Win XP SP2

Classhelp popups (Opened by clicking a (list) links 
next to a field) do not work.
Clicking on (list) opens a popup, and the selection is 
correctly updated when the checkboxes are toggled. 
But pressing either "Apply" or "Cancel" buttons has 
no effect. 
msg1568 Author: [hidden] (mstarzyk) Date: 2004-12-11 19:37
Logged In: YES 
user_id=657380

Here is a javascript log from Opera, for "Superseder (list)
".
msg1569 Author: [hidden] (mstarzyk) Date: 2004-12-11 23:49
Logged In: YES 
user_id=657380

And here is the patch. This is for the "classic" template, 
but I guess it should be applied to the "minimal" 
template as well. 

Index: templates/classic/html/_generic.help.html
=====================================
==============================
RCS file: /cvsroot/roundup/roundup/templates/classic/
html/_generic.help.html,v
retrieving revision 1.21
diff -u -r1.21 _generic.help.html
--- templates/classic/html/_generic.help.html	19 Oct 
2004 09:32:58 -0000	1.21
+++ templates/classic/html/_generic.help.html	11 Dec 
2004 23:42:09 -0000
@@ -11,7 +11,8 @@
       <script language="Javascript" type="text/javascript"
           tal:content="structure string:
           // this is the name of the field in the original 
form that we're working on
-          form  = window.opener.document.${request/
form/form/value};" >
+          form  = window.opener.document.${request/
form/form/value};
+          field  = '${request/form/property/value}';">
       </script>
       <script src="@@file/help_controls.js" type="text/
javascript"><!--
       //--></script>
msg1570 Author: [hidden] (richard) Date: 2004-12-14 23:27
Logged In: YES 
user_id=6405

Fixed, thanks for the patch. 
History
Date User Action Args
2004-12-11 19:26:57mstarzykcreate