Roundup Tracker - Issues

Issue 1429367

classification
New clear message link broken
Type: Severity: normal
Components: Web interface Versions:
process
Status: closed fixed
:
: richard : colus, dbyrne, nerijus, richard
Priority: normal :

Created on 2006-02-10 20:47 by anonymous, last changed 2006-03-03 01:00 by richard.

Messages
msg2140 Author: [hidden] (anonymous) Date: 2006-02-10 20:47
The clear message link always assumes that the error or
message occurs on an issue.  So if I add a user (say
the 9th user), and I get the green bar and click clear
message, I will then go to issue9 instead of user9.

My email is: David.Byrne@cambridge-na.com

Thanks,
David Byrne
msg2141 Author: [hidden] (nerijus) Date: 2006-02-11 12:04
Logged In: YES 
user_id=3416

Another problem:
When I logout and press "clear this message", I get Internal
Server Error.
Because it tries to open issueNone.
msg2142 Author: [hidden] (colus) Date: 2006-02-20 08:29
Logged In: YES 
user_id=247180

At classic template page.html

  <p tal:condition="options/ok_message | nothing"
class="ok-message">
    <span tal:repeat="m options/ok_message"
       tal:content="structure string:$m <br/ > " />
     <a class="form-small" tal:attributes="href
string:${context/_classname}${context/id}"
        i18n:translate="">clear this message</a>
  </p>

Fix "href string:issue${context/id}" to "href
string:${context/_classname}${context/id}". I guess this fix
will solve the problem.
msg2143 Author: [hidden] (dbyrne) Date: 2006-02-20 13:40
Logged In: YES 
user_id=53454

colus, That helps the problem with most situations.  It
unfortunately does not help with the problem when logging
off.  I've implemented your fix to at least fix the other cases.

Thanks,
David Byrne
msg2144 Author: [hidden] (anonymous) Date: 2006-03-01 03:06
Logged In: NO 

I hacked my personal tracker to do
---
href python:(context.id != None and ('issue' + context.id)
or '/misas/')
---

where misas is my tracker name.  This solved the logout
issue for me, but it most likely doesn't solve the issue
originally reported in this bug. :)  Maybe someone can
combine the two fixes to solve everything.

What I don't like in my fix above is that due to my limited
understanding of roundup source code, I had to hardcode my
tracker name into it. :(
msg2145 Author: [hidden] (richard) Date: 2006-03-01 03:38
Logged In: YES 
user_id=6405

I'm just going to implement a Javscript / CSS solution to 
this problem. No page reloading.  
msg2146 Author: [hidden] (richard) Date: 2006-03-03 01:00
Logged In: YES 
user_id=6405

I've implemented a better solution. Change the template to 
read: 
 
 <a class="form-small" tal:attributes="href 
request/current_url" 
          i18n:translate="">clear this message</a> 
 
Requires the latest code (1.1.1 will be released very 
soon) 
 
History
Date User Action Args
2006-02-10 20:47:04anonymouscreate