Issue 1436169
Created on 2006-02-21 21:03 by anonymous, last changed 2006-03-02 23:50 by richard.
msg2180 |
Author: [hidden] (anonymous) |
Date: 2006-02-21 21:03 |
|
I have version 1.1.0 installed and it is working great
except for one thing.
When I try to save a search it does not work. I click
the search link,
choose my criteria, and enter a name for the search and
the search
completes successfully, but is not saved.
The server is setup with the sqlite backend, apache is
setup as the
front end redirecting requests to the roundup daemon
(i.e., not
mod_python), and we use python2.4.
|
msg2181 |
Author: [hidden] (anonymous) |
Date: 2006-02-21 21:04 |
|
Logged In: NO
submitted by benchline (neglected to login before submitting).
|
msg2182 |
Author: [hidden] (dlinke) |
Date: 2006-02-28 22:41 |
|
Logged In: YES
user_id=734219
This problem can be reproduced also in the demo tracker if
you try to create more than on query. Below is a patch that
fixes the problem (verified for demo-tracker).
Index: roundup/cgi/actions.py
===================================================================
RCS file: /cvsroot/roundup/roundup/roundup/cgi/actions.py,v
retrieving revision 1.58
diff -u -r1.58 actions.py
--- roundup/cgi/actions.py 8 Feb 2006 04:03:54 -0000 1.58
+++ roundup/cgi/actions.py 28 Feb 2006 22:34:22 -0000
@@ -192,7 +192,7 @@
qids = self.db.query.filter(None,
{'name': old_queryname,
'creator': uid})
- if qids:
+ if qids and old_queryname:
# edit query - make sure we get an
exact match on the name
for qid in qids:
if old_queryname !=
self.db.query.get(qid, 'name'):
Unfortunately sf does not let me append a file :-/ I hope it
is still usable.
Regards,
David
|
msg2183 |
Author: [hidden] (anonymous) |
Date: 2006-03-01 03:00 |
|
Logged In: NO
I have the exact same bug with similar setup (sqlite
backend), but no apache, and running as a service on Windows.
|
msg2184 |
Author: [hidden] (anonymous) |
Date: 2006-03-01 10:19 |
|
Logged In: NO
I'm using Python 2.4 with anydbm, using the roundup-server
daemon directly, and I found the same problem.
The steps I took that resulted in this problem are as follows:
I created a search and gave it a name. It seemed to save
perfectly at first.
I then made the search public.
I then created another search, and tried to save that. It
didn't work.
I removed the existing search from my list of saved queries
and tried to again create a new saved search. This time, it
resulted in reactivating the previous search I had just removed.
Repeating these steps may result in the same error, and may
provide some clue to the problem.
|
msg2185 |
Author: [hidden] (anonymous) |
Date: 2006-03-01 10:29 |
|
Logged In: NO
dlinke's fix also works on a development round-server, as
well as the demo. A copy and paste of the patch didn't work,
but doing it manually by changing "if qids:" to "if qids and
old_queryname:" on line 192 of roundup/cgi/actions.py did.
|
msg2186 |
Author: [hidden] (anonymous) |
Date: 2006-03-01 20:17 |
|
Logged In: NO
dlink's fix does not work, except superficially. When you
delete a query, it stops working.
|
msg2187 |
Author: [hidden] (dlinke) |
Date: 2006-03-01 20:45 |
|
Logged In: YES
user_id=734219
"Nobody", what do you mean by "does not work" and "it stops
working"? I can delete queries and I can also create an
additional new query or edit any existing query after
deleting a query.
|
msg2188 |
Author: [hidden] (anonymous) |
Date: 2006-03-01 22:07 |
|
Logged In: NO
dlinke: well I applied your fix and indeed I was able to
make a second query. However, I had a query made before I
applied your fix and it was in the "retired" state. After
applying your fix, I wanted to recreate a query with the
exact same name, but it wouldn't let me. So I clied "edit"
and selected "remove" and it went away instead of just being
"retired". Ah good, I thought. So I make a new query with
the same name, and no go. So I figure, my query-related
stuff is corrupted in DB or something, so I try to make any
other query and I cannot. I am back to where I was. Maybe
it's because I royally messed up my roundup tracker, but at
this time I have many issues in it and I don't want to reset it.
So maybe your fix only works for people who haven't done
what I did prior to installing it? I don't know. All I
know is that I have it in now and I can't make more queries.
--Leo
|
msg2189 |
Author: [hidden] (anonymous) |
Date: 2006-03-01 22:33 |
|
Logged In: NO
dlinke: by the way, I can still make 1 save query. I just
can't make more than 1, seems like.
--Leo
|
msg2190 |
Author: [hidden] (richard) |
Date: 2006-03-02 23:50 |
|
Logged In: YES
user_id=6405
|
|
Date |
User |
Action |
Args |
2006-02-21 21:03:55 | anonymous | create | |
|