Roundup Tracker - Issues

Issue 2550535

classification
Mail gateway borks quotes and console sessions
Type: behavior Severity: normal
Components: Mail interface Versions: 1.4
process
Status: closed fixed
:
: schlatterbeck : ThomasAH, ajaksu2, schlatterbeck
Priority: : patch

Created on 2009-04-07 20:30 by ajaksu2, last changed 2012-01-26 15:41 by ThomasAH.

Files
File name Uploaded Description Edit Remove
fix_quotes.diff ajaksu2, 2009-04-07 20:30 Fix roundup.mailgw.parseContent for-else/keep_citations logic
Messages
msg3685 Author: [hidden] (ajaksu2) Date: 2009-04-07 20:30
In the original code, a for-else is used with wrong logic, so that if
there was a response ('no blank line between quoted message and
response') in the section, the loop would break and not execute the
else[1]. Unfortunately, the code that checks whether to include the
quoted text verbatim is inside the else clause.

Attached patch fixes this and reorganizes the code a bit. Also tracked
at http://psf.upfronthosting.co.za/roundup/meta/issue264
msg4469 Author: [hidden] (schlatterbeck) Date: 2012-01-05 16:31
Daniel, I've looked into this and also studied issues  264 and 321 in
your meta tracker.
Are we talking about the same settings in config.ini:
- keep_quoted_text = no
- leave_body_unchanged = no

With these I'm not seeing the same results with the original message in 
http://psf.upfronthosting.co.za/roundup/meta/file197/msg99926-orig.txt
and outcome in http://bugs.python.org/msg99926 -- neither with nor
without your patch.

- Without the patch *all* quoted text is stripped -- and I've always
  thought that this is the intention of "keep_quoted_text=no" (that's
  why I'm usually turning it to "yes" in my trackers)
- with your patch the *last line* of quoted text is kept if an empty
  line follows (if the user directly replies to a portion of quoted
  text without an empty line after the quote, the quote is still
  stripped)
So I'm unsure what the patch should have achieved and can't reproduce
the current behaviour of bugs.python.org. I've not yet closely looked at
your code in the patch, though.

I think what really *would* be nice is a heuristic that strips quotes
only if the user did top- or bottom-quoting for the whole message, it
should try to keep quotes in case the user did some effort in citing
specific portions of the original message.
msg4470 Author: [hidden] (schlatterbeck) Date: 2012-01-05 17:39
Ah. You're using "keep_quoted_text = yes" and it doesn't -- sometimes.
I see the purpose of your fix but it seems to break keep_quoted_text = no
msg4471 Author: [hidden] (schlatterbeck) Date: 2012-01-05 19:59
fixed in git 709f252
History
Date User Action Args
2012-01-26 15:41:14ThomasAHsetnosy: + ThomasAH
2012-01-05 19:59:18schlatterbecksetstatus: new -> closed
assignee: schlatterbeck
resolution: fixed
messages: + msg4471
2012-01-05 17:39:26schlatterbecksetmessages: + msg4470
2012-01-05 16:31:56schlatterbecksetnosy: + schlatterbeck
messages: + msg4469
2009-04-07 20:30:16ajaksu2create