Message4469
Daniel, I've looked into this and also studied issues 264 and 321 in
your meta tracker.
Are we talking about the same settings in config.ini:
- keep_quoted_text = no
- leave_body_unchanged = no
With these I'm not seeing the same results with the original message in
http://psf.upfronthosting.co.za/roundup/meta/file197/msg99926-orig.txt
and outcome in http://bugs.python.org/msg99926 -- neither with nor
without your patch.
- Without the patch *all* quoted text is stripped -- and I've always
thought that this is the intention of "keep_quoted_text=no" (that's
why I'm usually turning it to "yes" in my trackers)
- with your patch the *last line* of quoted text is kept if an empty
line follows (if the user directly replies to a portion of quoted
text without an empty line after the quote, the quote is still
stripped)
So I'm unsure what the patch should have achieved and can't reproduce
the current behaviour of bugs.python.org. I've not yet closely looked at
your code in the patch, though.
I think what really *would* be nice is a heuristic that strips quotes
only if the user did top- or bottom-quoting for the whole message, it
should try to keep quotes in case the user did some effort in citing
specific portions of the original message. |
|
Date |
User |
Action |
Args |
2012-01-05 16:31:56 | schlatterbeck | set | messageid: <1325781116.82.0.859708397239.issue2550535@psf.upfronthosting.co.za> |
2012-01-05 16:31:56 | schlatterbeck | set | recipients:
+ schlatterbeck, ajaksu2 |
2012-01-05 16:31:56 | schlatterbeck | link | issue2550535 messages |
2012-01-05 16:31:56 | schlatterbeck | create | |
|