Roundup Tracker - Issues

Issue 2550574

classification
roundup-1.4.9 tarball does not contain additional detectors
Type: Severity: normal
Components: Installation Versions: 1.4
process
Status: closed fixed
:
: : ThomasAH, ber, richard, stefan, tonimueller, wking
Priority: :

Created on 2009-08-13 15:08 by ThomasAH, last changed 2012-08-08 10:26 by ber.

Files
File name Uploaded Description Edit Remove
newitemcopy.py wking, 2012-05-15 16:53
Messages
msg3845 Author: [hidden] (ThomasAH) Date: 2009-08-13 15:08
The detectors directory of 1.4.8 contains:
creator_resolution.py  emailauditor.py  newissuecopy.py

In 1.4.9 the directory does not exist.
msg3846 Author: [hidden] (ThomasAH) Date: 2009-08-13 15:29
In the svn repository I found:

------------------------------------------------------------------------
r4221 | stefan | 2009-06-17 03:45:25 +0200 (Wed, 17 Jun 2009) | 1 line

Remove obsolete detectors.
------------------------------------------------------------------------

But this isn't mentioned in the changelog or release notes,
and I still have to look at the current docs what I should use instead
of newissuecopy.py
msg3847 Author: [hidden] (ThomasAH) Date: 2009-08-13 15:30
doc/customizing.txt still contains the section
"Additional Detectors Ready For Use"
talking about the three deleted detectors.
msg3848 Author: [hidden] (ThomasAH) Date: 2009-08-14 13:53
On IRC stefan said that he removed the detectors directory because it is
not used by the tracker templates.
He said there is no reason for the Roundup project to ship them, they
can easily be written by end-users.

Personally I think newissuecopy.py is very precious, even if it is
simple enough that advanced end-users would be able to write it on their
own.
Just changing one email address simply is more convenient than that.
msg3849 Author: [hidden] (tonimueller) Date: 2009-08-15 16:59
Personally, I think that a batch of sample code is really nice to have
to get started. I also think that shipping three small files should not
hurt anyone.
msg3850 Author: [hidden] (tonimueller) Date: 2009-08-15 17:18
In any case, the change wasn't fully executed, as setup.py still
mentions the detectors subdirectory.
msg3857 Author: [hidden] (ThomasAH) Date: 2009-08-20 07:30
adding stefan to nosy
msg3872 Author: [hidden] (ber) Date: 2009-09-09 07:30
FWIW: I also agree that shipping essential buildings blocks is a good 
idea. The only potential issues I see is that the documentation might
not match the shipped script anymore, but I propose to solve this by 
generating the documentation out of the script, so that this is only 
one source.
msg4013 Author: [hidden] (richard) Date: 2010-02-02 05:08
I would like the sample detectors back too ;)
msg4557 Author: [hidden] (wking) Date: 2012-05-15 16:54
I also agree that `newissuecopy.py' is important.  After reading the
config comments:

  # The 'dispatcher' is a role that can get notified
  # of new items to the database.

It seems to me that DISPATCHER_EMAIL should be notified of all new
items, not just bounced messages as is currently hardcoded into
Mailer.bounce_message.

I've attached a tweaked version of `newissuecopy.py' that implements
this for all items.  I thing that a number of email-generating methods
from IssueClass should actually be Item methods, so they can also be
used on non-Issue nodes.  This would remove a lot of the duplicated
code from my `newitemcopy.py'
msg4561 Author: [hidden] (ThomasAH) Date: 2012-05-16 08:10
* W. Trevor King <issues@roundup-tracker.org> [20120515 18:54]:
> I also agree that `newissuecopy.py' is important.  After reading the
> config comments:
> 
>   # The 'dispatcher' is a role that can get notified
>   # of new items to the database.
> 
> It seems to me that DISPATCHER_EMAIL should be notified of all new
> items, not just bounced messages as is currently hardcoded into
> Mailer.bounce_message.
> 
> I've attached a tweaked version of `newissuecopy.py' that implements
> this for all items.  I thing that a number of email-generating methods
> from IssueClass should actually be Item methods, so they can also be
> used on non-Issue nodes.  This would remove a lot of the duplicated
> code from my `newitemcopy.py'

We nearly always use newissuecopy.py to inform some users or a
public mailing list about new issues (or in one case new merge
entries), but not about everything.

DISPATCHER_EMAIL is the supervisor who wants to be notified about
everything, so this is something different.

First step should be to revive the removed detectors. But yes,
providing more flexibility with less code duplication would be nice,
as would be the possibility to set the newissuecopy recipients in
config.ini (without preventing configuration in newissuecopy.py
itself of course).

Regards,
Thomas
msg4562 Author: [hidden] (ThomasAH) Date: 2012-05-16 09:27
I went ahead and restored the detectors in changeset 6b32e9dac625
(directly after 1.4.20), but I can't change the status of this issue.
msg4600 Author: [hidden] (ber) Date: 2012-08-01 18:55
Trevor, can you open a new issue with your improvement please? 
(As this issue is quite specific about restoring the old situation. I believe you are
changing some of the conditions how this is used and I haven't fully thought it 
through.)
msg4602 Author: [hidden] (wking) Date: 2012-08-01 19:26
On Wed, Aug 01, 2012 at 06:55:54PM +0000, Bernhard Reiter wrote:
> Trevor, can you open a new issue with your improvement please? 

Split off as issue2550767.
History
Date User Action Args
2012-08-08 10:26:04bersetstatus: open -> closed
2012-08-01 19:26:45wkingsetmessages: + msg4602
2012-08-01 18:55:54bersetmessages: + msg4600
2012-08-01 18:53:09bersetstatus: new -> open
assignee: stefan ->
resolution: fixed
2012-05-16 09:27:10ThomasAHsetmessages: + msg4562
2012-05-16 08:10:30ThomasAHsetmessages: + msg4561
2012-05-15 16:54:00wkingsetfiles: + newitemcopy.py
nosy: + wking
messages: + msg4557
2010-02-02 05:08:01richardsetnosy: + richard
messages: + msg4013
2009-09-09 07:30:00bersetmessages: + msg3872
2009-09-08 21:42:46bersetnosy: + ber
2009-08-20 07:30:11ThomasAHsetnosy: + stefan
messages: + msg3857
2009-08-15 17:18:42tonimuellersetmessages: + msg3850
2009-08-15 16:59:52tonimuellersetnosy: + tonimueller
messages: + msg3849
2009-08-14 13:53:36ThomasAHsetmessages: + msg3848
2009-08-14 13:48:35stefansetassignee: stefan
2009-08-13 15:30:38ThomasAHsetmessages: + msg3847
2009-08-13 15:29:18ThomasAHsetmessages: + msg3846
2009-08-13 15:08:48ThomasAHcreate