Roundup Tracker - Issues

Issue 2550782

classification
irker detector for Roundup
Type: rfe Severity: normal
Components: Versions: 1.4
process
Status: closed fixed
:
: ezio.melotti : ber, ezio.melotti
Priority: normal : patch

Created on 2012-11-15 13:22 by ezio.melotti, last changed 2013-01-02 20:12 by ber.

Files
File name Uploaded Description Edit Remove
irker.py ezio.melotti, 2012-11-15 13:22 irker detector
issue2550782.diff ezio.melotti, 2012-12-14 11:57
issue2550782-2.diff ezio.melotti, 2012-12-14 14:32
Messages
msg4673 Author: [hidden] (ezio.melotti) Date: 2012-11-15 13:22
Now that CIA is dead I wrote a new Roundup detector that uses irker
[0][1] instead of CIA.  It requires the irc package [2] and the irker
daemon running in background.
It's also necessary to add 
  [irker]
  channels = irc://chat.freenode.net/channelname
to detectors/config.ini to make it work.

We have been using this on bugs.python.org for a while and it seems to
work fine [3].

[0]: http://www.catb.org/esr/irker/
[1]: http://esr.ibiblio.org/?p=4607
[2]: http://pypi.python.org/pypi/irc/
[3]: http://psf.upfronthosting.co.za/roundup/meta/issue483
msg4674 Author: [hidden] (ber) Date: 2012-11-15 16:16
Ezio,
sounds like a good idea to have.
Are there any drawbacks if we include in the disribution?
If we it should be on the wiki or documented. ;)

Bernhard
msg4675 Author: [hidden] (ezio.melotti) Date: 2012-11-15 18:13
The detector should be fine, since the format used to send messages to
irker is not going to change (it worked without changes on all the irker
versions I used -- from 1.0 to 1.13).
OTOH irker is still relatively young and has a few minor problems.  The
latest version also requires irc3.4+, and AFAIU doesn't work with older
versions, so users might encounter some issues while
installing/configuring it.
msg4693 Author: [hidden] (ezio.melotti) Date: 2012-12-14 10:14
I was looking for cia.py, but it doesn't seem to be included in the tree.
I found two places where the detector could be added:
 1)
http://roundup.hg.sourceforge.net/hgweb/roundup/roundup/file/default/detectors
 2)
http://roundup.hg.sourceforge.net/hgweb/roundup/roundup/file/118457ca2e07/share/roundup/templates/devel/detectors

The other templates also have a detectors dir.
Where should I add the detector?
Should I add instructions about it somewhere?
msg4694 Author: [hidden] (ber) Date: 2012-12-14 11:25
Ezio,

If the detector can be used for all templates, I think
a common directory is fitting, so 1).

docs/customizing.txt section detectors-adding-behaviour-to-your-tracker
additional detectors reader for use.

Best,
Bernhard
msg4695 Author: [hidden] (ezio.melotti) Date: 2012-12-14 11:57
The attached patch adds irker.py to the detectors dir, a CHANGES entry,
and an entry in doc/customizing.txt, however I noticed that the
detectors listed there are the ones installed with the templates, and
the list is not even updated.
Should I move the detector in the detectors dirs under templates/
instead or should I create a separate section in customizing.txt?  Are
the instructions I wrote clear enough?
msg4696 Author: [hidden] (ber) Date: 2012-12-14 12:47
Move the description in a lower section within customizing.txt, 
the one I've mentioned in msg4674: "Additional Detectors Ready For Use"

I cannot judge if the documentation is sufficient, as I don't know
ircer myself. You could add some more documentation to the detector
files itself, i'd say and keep the customizing section less specific.
(Just an idea.)
msg4697 Author: [hidden] (ezio.melotti) Date: 2012-12-14 14:32
Sorry, I misread your message.  I now moved the description in the right
section, and added some more documentation in the detector itself.
If the new patch looks good I'll commit it.
msg4698 Author: [hidden] (ber) Date: 2012-12-14 15:32
Go ahead. :)
msg4699 Author: [hidden] (ezio.melotti) Date: 2012-12-14 16:24
Done in 132650f4700a.
msg4711 Author: [hidden] (ber) Date: 2013-01-02 20:12
Published with 1.4.21.
History
Date User Action Args
2013-01-02 20:12:28bersetstatus: new -> closed
messages: + msg4711
2012-12-14 16:24:22ezio.melottisetresolution: fixed
messages: + msg4699
2012-12-14 15:32:31bersetmessages: + msg4698
2012-12-14 14:32:45ezio.melottisetfiles: + issue2550782-2.diff
messages: + msg4697
2012-12-14 12:47:28bersetnosy: - schlatterbeck
messages: + msg4696
2012-12-14 11:57:22ezio.melottisetfiles: + issue2550782.diff
keywords: + patch
messages: + msg4695
2012-12-14 11:25:13bersetnosy: + schlatterbeck
messages: + msg4694
2012-12-14 10:14:14ezio.melottisetmessages: + msg4693
2012-11-15 18:13:16ezio.melottisetmessages: + msg4675
2012-11-15 16:16:05bersetnosy: + ber
messages: + msg4674
2012-11-15 13:22:58ezio.melotticreate