Created on 2017-04-29 17:20 by paulschreiber, last changed 2019-12-25 02:35 by rouilj.
|msg5970||Author: [hidden] (paulschreiber)||Date: 2017-04-29 17:20|
Allow users to log in to bugs.python.org/issues.roundup-tracker.org with their email address in the username field. Currently, this fails with an "Invalid login" error. Originally filed as http://psf.upfronthosting.co.za/roundup/meta/issue617
|msg5990||Author: [hidden] (rouilj)||Date: 2017-07-28 02:24|
I am not clear what is wanted here. You can change your login name to your email address if you want this. What is the use case for allowing multiple login names? -- rouilj
|msg6000||Author: [hidden] (paulschreiber)||Date: 2017-08-02 15:35|
As you require the creation of a username separate from the email address, which is different from most other websites, it follows that users will attempt to log in with their email address. WordPress, which requires usernames, lets users log in via both email address and username. This would be a easy fix ( where USERNAME = <blah> OR EMAIL_ADDRESS = <blah>), a usability improvement, and a reduction in support time/costs.
|msg6001||Author: [hidden] (rouilj)||Date: 2017-08-02 22:19|
Hi Paul: In message <email@example.com .za>, Paul Schreiber writes: >As you require the creation of a username separate from the email >address, which is different from most other websites, it follows >that users will attempt to log in with their email address. Ok fair enough. Also I believe that you can use your email address as your login name (or change your login name to one of your email addresses). However if you do so, you will probably be exposing your email in the web interface where the username usually shows up. I don't think we obscure email addresses in that position. Also I assume you mean only the primary email address (which is used to send email to the user) and not any additional addresses (which are used to receive emails and map them to the user). >This would be a easy fix ( where USERNAME = <blah> OR >EMAIL_ADDRESS = <blah>), a usability improvement, and >a reduction in support time/costs. This would go in the core login code and would need to be controllable by the tracker admin. I would be in favor of having a patch that implemented this included in the core code.
|msg6008||Author: [hidden] (rouilj)||Date: 2017-09-04 20:48|
Since this is not a bug, I am changing type to RFE (request for enhancement). Also marking as possible gsoc and I think effort level should be low.
|msg6856||Author: [hidden] (rouilj)||Date: 2019-12-25 02:35|
Actually I think this can be done on a per tracker instance. In interfaces.py create a new login action that wraps the login action in cgi/action.py. This new login action checks to see if __login_name exits in self.form. Then checks to see if self.form['__login_name'].value is a valid user. If not, search for a user with a matching email address. If you find one, change the value of __login_name to the user's name then call the handler for the LoginAction class. There is about 10 lines of replicated code from the top of the handler for the LoginAction class to do this, but I think it could work. If it does, we should be able to reuse the logic as a patch to the LoginAction handler.
|2019-12-25 02:35:53||rouilj||set||messages: + msg6856|
+ Effort-Low, GSOC|
type: behavior -> rfe
messages: + msg6008
|2017-08-02 22:19:49||rouilj||set||messages: + msg6001|
|2017-08-02 15:35:39||paulschreiber||set||messages: + msg6000|
messages: + msg5990