Roundup Tracker - Issues

Issue 565992

classification
roundup may create bad links
Type: Severity: normal
Components: Web interface Versions:
process
Status: closed rejected
:
: dman13 : dman13, gmcm, richard
Priority: normal :

Created on 2002-06-07 21:25 by gmcm, last changed 2002-06-14 03:57 by dman13.

Messages
msg250 Author: [hidden] (gmcm) Date: 2002-06-07 21:25
In certain situations, the instance name may be missing.

Using roundup-server:
  use http://host:port/instance (no trailing slash)
  the urls in the issue list are missing the instance name,
     (ie, http://host:port/issue3 )
msg251 Author: [hidden] (richard) Date: 2002-06-11 06:45
Logged In: YES 
user_id=6405

How did the URL get generated? If it's generated by Roundup,   
then sure, we have a problem. If it isn't, then short of adding a   
<base> tag, there's really not much to be done.  We  
specifically removed the <base> tag waaaay back in  
Roundup's past because it caused lots of problems. I'd really  
like to avoid having one if at all possible.  
 
msg252 Author: [hidden] (gmcm) Date: 2002-06-11 15:46
Logged In: YES 
user_id=4923

I logged this mainly because I was mystified as to why it
behaves this way. I think it can be fixed by slapping in a
trailing '/' when the cgi path is being examined (maybe
inner_run_cgi ?). The more I looked, the more everything
*looked* like it should work, though, and that bothered me
more than the problem itself :-).


msg253 Author: [hidden] (richard) Date: 2002-06-12 00:26
Logged In: YES 
user_id=6405

It behaves this way because all links generated by Roundup 
are relative and at the same path level within an instance. So 
if the instance is accessed with a url that doesn't indicate that 
the instance is a "folder" to the browser, then the relative links 
will appear to be at the same path level as the instance itself, 
which is wrong. We need the trailing slash for this reason. 
 
Since the issue first came up, there's been a need to be able 
to generate an absolute URL (for the classhelp popup), so we 
should be able to fix this. 
msg254 Author: [hidden] (richard) Date: 2002-06-13 21:54
Logged In: YES 
user_id=6405

If it's not roundup generating the bad links, it's not a bug. 
msg255 Author: [hidden] (anonymous) Date: 2002-06-13 22:23
Logged In: NO 

The same problem exists in the e-mails generated by roundup.
msg256 Author: [hidden] (dman13) Date: 2002-06-13 23:19
Logged In: YES 
user_id=555791

I'll fix the email situation.

Otherwise, just add a trailing '/' to ISSUE_TRACKER_WEB in
your instance_config.py.
msg257 Author: [hidden] (dman13) Date: 2002-06-14 03:57
Logged In: YES 
user_id=555791

fixed in CVS -- if ISSUE_TRACKER_WEB is missing the trailing '/', it will now be added
History
Date User Action Args
2002-06-07 21:25:59gmcmcreate