Issue 2550763
Created on 2012-06-29 18:49 by wking, last changed 2016-06-06 00:50 by rouilj.
msg4586 |
Author: [hidden] (wking) |
Date: 2012-06-29 18:49 |
|
words =+ patch]"
> >
> > Perhaps a strip() is in order. Or should the user remove the spaces
> > when composing the subject?
>
> Probably the best workaround is to not use spaces for now, I'm not sure
> what other repercussions a strip there could have (not only keywords are
> parsed that way).
> If you think it's safe I'm open for a patch :-)
Spaces are already stripped from the property name. I don't see what
harm stripping them from the property value could have.
|
msg4587 |
Author: [hidden] (wking) |
Date: 2012-07-02 14:06 |
|
My earlier patch didn't fix the issue. Bookmark issue2550763 on
ssh://hg@bitbucket.org/wtking/roundup
should fix it now (with a test and CHANGES.txt entry).
|
msg5581 |
Author: [hidden] (rouilj) |
Date: 2016-06-05 20:09 |
|
Hi Trevor:
Can you tell me how to get your changes from:
ssh://hg@bitbucket.org/wtking/roundup
in patch form? All I get is a permission denied error
when trying to log in.
I can see the diffs (I think) using:
https://bitbucket.org/wtking/roundup/branches/compare/issue2550763%0Dmaster#diff
with the issue tag/bookmark as the source and the master as the destination.
But there is no way to generate a patch file from that AFAICT.
-- rouilj
|
msg5582 |
Author: [hidden] (wking) |
Date: 2016-06-05 22:26 |
|
On Sun, Jun 05, 2016 at 08:09:46PM +0000, John Rouillard wrote:
> Can you tell me how to get your changes from:
>
> ssh://hg@bitbucket.org/wtking/roundup
>
> in patch form?
I'm not particularly familiar with Mercurial, so there's probably a
better way to do this. But after cloning the repository:
$ hg clone ssh://hg@bitbucket.org/wtking/roundup
$ cd roundup
You can see the commits as patches:
$ hg log -p -r master..issue2550763
Or use patchbomb [1] to write them to an mbox:
$ hg email -m patches.mbox -r master..issue2550763
In both cases, that pulls in the master commit from my repo
(4636:f338c19b0a6d), so you either want to ignore that commit or
change the rev options to ‘-r 5473d677a151..issue2550763’.
[1]: https://www.mercurial-scm.org/wiki/PatchbombExtension
|
msg5583 |
Author: [hidden] (rouilj) |
Date: 2016-06-05 22:53 |
|
Hi Trevor:
In message <20160605222609.GR5011@odin.tremily.us>,
"W. Trevor King" writes:
>On Sun, Jun 05, 2016 at 08:09:46PM +0000, John Rouillard wrote:
>> Can you tell me how to get your changes from:
>>
>> ssh://hg@bitbucket.org/wtking/roundup
>>
>> in patch form?
>
>I'm not particularly familiar with Mercurial, so there's probably a
>better way to do this. But after cloning the repository:
>
> $ hg clone ssh://hg@bitbucket.org/wtking/roundup
> $ cd roundup
Well that's the problem, I can't clone it. Is there an anonymous
mechanism to clone it?
|
msg5584 |
Author: [hidden] (wking) |
Date: 2016-06-05 23:10 |
|
On Sun, Jun 05, 2016 at 10:53:59PM +0000, John Rouillard wrote:
> Well that's the problem, I can't clone it. Is there an anonymous
> mechanism to clone it?
Oops, sorry about that. Try:
$ hg clone https://bitbucket.org/wtking/roundup
|
msg5585 |
Author: [hidden] (rouilj) |
Date: 2016-06-06 00:50 |
|
Commited on: 2706b66675bf
I changed the test case. As written from the patch I didn't get it to work.
However it is now working and the subject line is:
Subject: [issue1] set keyword [ keyword =+ Foo,Baz This ; nosy =+ mary ]
so this should test a couple of types of links (keywords as well as user).
Thanks for the patch.
|
|
Date |
User |
Action |
Args |
2016-06-06 00:50:46 | rouilj | set | status: open -> closed resolution: fixed messages:
+ msg5585 |
2016-06-05 23:10:17 | wking | set | messages:
+ msg5584 |
2016-06-05 22:53:59 | rouilj | set | messages:
+ msg5583 |
2016-06-05 22:26:14 | wking | set | messages:
+ msg5582 |
2016-06-05 20:09:46 | rouilj | set | status: new -> open priority: normal messages:
+ msg5581 nosy:
+ rouilj assignee: rouilj |
2012-07-02 14:06:49 | wking | set | messages:
+ msg4587 title: mailgw.py: strip whitespace from subject property values -> hyperdb.py: strip Multilink values after + or -. |
2012-06-29 18:49:12 | wking | create | |
|